User: Enable roles combination - refs #5648 #6206
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| $feature = api_detect_feature_context(); | ||
| $permission = $feature.':edit'; | ||
|
|
||
| return api_get_permission($permission, $userRoles); |
There was a problem hiding this comment.
Avoid too many return statements within this method.
| return api_get_permission($permission, $userRoles); | ||
| } | ||
|
|
||
| return $isAllowed; |
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit 20b053a and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
public/main/admin/user_list.php
Outdated
| $status_options | ||
| 'keyword_roles', | ||
| get_lang('Roles'), | ||
| array_combine(api_get_roles(), api_get_roles()), |
There was a problem hiding this comment.
The select input should show the roles by their translated values.
The translated variables are as follow:
- ROLE_STUDENT: Learner
- ROLE_ADMIN: Admin
- ROLE_SUPER_ADMIN: Super admin
- ROLE_GLOBAL_ADMIN: Global admin
- ROLE_TEACHER: Teacher
- ROLE_HR: Human Resources Manager
- ROLE_QUESTION_MANAGER: Question manager
- ROLE_SESSION_MANAGER: Session administrator
- ROLE_STUDENT_BOSS: Superior (n+1)
- ROLE_INVITEE: Invitee
Considering we do not have such a "translations" table for roles, I would put that directly (hardcoded) into the api_get_roles() function. We will take care of that in C3.
Just a note for myself: a global admin is the person who initially installed the system (just a detail vs the super admin, which is the person managing all URLs in a multi-URL context).
|
@christianbeeznest aquí falta mostrar los roles en su versión traducida y corregir el conflicto de merge |
…ated role labels, multi-role search
christianbeeznest
force-pushed
the
GH-5648
branch
from
20b053a to
07656bf
Compare
Esta agregado las traducciones y corregido los conflictos. |
|
Confirmed together with @christianbeeznest that this is an elegant way to transition from legacy-permissions (only about 13 roles, most mutually-exclusive) to a new system of combination of roles that have given permissions each. |
No description provided.